[FSSDK-11373] add holdout support and refactor decision logic in DefaultDecisionService #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muzahidul-opti
changed the title
muzahidul-opti
changed the title
jaeopt
requested changes
Apr 28, 2025
Comment on lines
+272
to
+283
| let holdouts = config.getHoldoutForFlag(id: featureFlag.id) | ||
| for holdout in holdouts { | ||
| let dicisionResponse = getVariationForHoldout(config: config, | ||
| flagKey: featureFlag.key, | ||
| holdout: holdout, | ||
| user: user) | ||
| reasons.merge(dicisionResponse.reasons) | ||
| if let variation = dicisionResponse.result { | ||
| let featureDicision = FeatureDecision(experiment: holdout, variation: variation, source: Constants.DecisionSource.holdout.rawValue) | ||
| return DecisionResponse(result: featureDicision, reasons: reasons) | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we move this up to the upper level like - since it's more like for flag not flag experiments.
decide flag {
checkVariationForHoldout()
getVariationForFeatureExperiments()
getVariationForRollout()
}
|
|
||
| func getVariationForFeatureExperiment(config: ProjectConfig, |
There was a problem hiding this comment.
Why do we rename it? This method evaluate only "experiments" part of a flag, so the original name may be more clear, differentiated from the other part getVariationForFeatureRollout below?
| - Parameter bucketingId: The ID to bucket. This must be a non-null, non-empty string. | ||
| - Returns: The variation the bucketingId was bucketed into. | ||
| */ | ||
| func bucketToVariation(experiment: ExperimentCore, |
There was a problem hiding this comment.
Are we adding new signature to this public protocol? This may break existing custom implementations on client side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ExperimentCoreto replaceExperimentin several methods across the codebase.DefaultDecisionServicefor improved readability and holdout support.getVariationForHoldoutmethod to evaluate holdout conditions and bucket users into holdouts.OPTBucketerprotocol by adding the newbucketToVariationmethod.BucketTests_HoldoutToVariation.swift,DecisionServiceTests_Features_Holdouts.swift,OptimizelyUserContextTests_Decide_Holdouts.swift,OptimizelyUserContextTests_Decide_With_Holdouts_Reasons.swiftTest plan
Issues